sdedic commented on code in PR #4317:
URL: https://github.com/apache/netbeans/pull/4317#discussion_r912343821
##########
platform/o.n.bootstrap/src/org/netbeans/ModuleManager.java:
##########
@@ -1572,10 +1610,15 @@ private final Set<Module> calculateParents(Module m)
throws NumberFormatExceptio
Collection<Module> fragments = getAttachedFragments(m);
if (!fragments.isEmpty()) {
for (Module frag : fragments) {
- Set<Module> mods = calculateParents(frag);
- mods.remove(m);
- res.addAll(mods);
+ if (isOrWillEnable(frag)) {
+ Set<Module> mods = calculateParents(frag);
+ res.addAll(mods);
+ }
}
+ // remove m and m's fragments from parent classloaders, as fragment
Review Comment:
remove(m) moved out of the loop, added fragments to prevent circularty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
