vieiro commented on PR #4327: URL: https://github.com/apache/netbeans/pull/4327#issuecomment-1173372320
Looks fine to me, @matthiasblaesing . Yep, this looks like a threading issue (probably the IDE has already told the LSP server that the file is closed, but the message is probably still queued in another RequestProcessor, and although probably sent, it has not reached the LSP server yet). There're some faiulres in tests, but these seem unrelated to the commit to me. One of the failure reads: ``` 2022-07-03T20:40:17.4283417Z [junit] 2022-07-03T20:40:17.4283922Z [junit] 2022-07-03T20:40:22.2342797Z [junit] java.lang.AssertionError: Has to be NbRepository: org.openide.filesystems.Repository@51b9c375 2022-07-03T20:40:22.2353885Z [junit] at org.netbeans.core.startup.Main.start(Main.java:298) 2022-07-03T20:40:22.2354312Z [junit] at org.netbeans.core.startup.TopThreadGroup.run(TopThreadGroup.java:98) 2022-07-03T20:40:22.2354723Z [junit] at java.base/java.lang.Thread.run(Thread.java:829) 2022-07-03T20:40:22.2355358Z [junit] ------------------------------------------------------------------------------- 2022-07-03T20:40:22.2355740Z [junit] >Log Session: Sunday, July 3, 2022 at 8:40:21 PM Coordinated Universal Time 2022-07-03T20:40:22.2356013Z [junit] >System Info: ``` There was a bug report for the `java.lang.AssertionError: Has to be NbRepository` , I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
