timboudreau commented on PR #1639: URL: https://github.com/apache/netbeans/pull/1639#issuecomment-1184650489
Inasmuch as I remember the code, the changes - as far as I can tell - seem reasonable, and adding a test is good. The patch contains a lot of formatting changes that makes it very hard to tell what really is different. But if it works, I'd say go for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
