mbien commented on code in PR #4390:
URL: https://github.com/apache/netbeans/pull/4390#discussion_r922678971
##########
java/java.j2seplatform/src/org/netbeans/modules/java/j2seplatform/platformdefinition/DefaultPlatformImpl.java:
##########
@@ -84,6 +102,12 @@ static JavaPlatform create(Map<String,String> properties,
List<URL> sources, Lis
return new DefaultPlatformImpl(installFolders, properties,
systemProperties, sources, javadoc);
}
+ private static boolean isValidJDKHome(Path javaHome) {
+ return Files.exists(javaHome.resolve(Path.of("bin", "java")))
+ && Files.exists(javaHome.resolve(Path.of("bin", "javac")));
+// && Files.exists(javaHome.resolve(Path.of("jmods",
"java.base.mod"))); // TODO: uncomment once everything migrated to 11+
Review Comment:
@neilcsmith-net I should have let you do the PR. It probably took you as
much time answering my questions as if you would have done it right away. Its
just that I had it already started together with the NPE PR and split it later,
since i thought this one would require UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
