matthiasblaesing commented on code in PR #4378:
URL: https://github.com/apache/netbeans/pull/4378#discussion_r922821698
##########
enterprise/websvc.jaxwsmodel/src/org/netbeans/modules/websvc/api/jaxws/bindings/impl/BindingsQName.java:
##########
@@ -34,14 +34,15 @@ public enum BindingsQName {
HANDLER_CLASS(createHandlerQName("handler-class")),
HANDLER_NAME(createHandlerQName("handler-name")),
BINDINGS(createBindingsQName("bindings"));
-
+
public static final String JAVAEE_NS_URI =
"http://java.sun.com/xml/ns/javaee";;
+ public static final String JAKARTAEE_NS_URI =
"https://jakarta.ee/xml/ns/jakartaee";;
public static final String JAVAEE_NS_PREFIX = "jws";
public static final String JAXWS_NS_URI =
"http://java.sun.com/xml/ns/jaxws";;
public static final String JAXWS_NS_PREFIX = "jaxws";
public static QName createHandlerQName(String localName) {
- return new QName(JAVAEE_NS_URI, localName, JAVAEE_NS_PREFIX);
+ return new QName(JAKARTAEE_NS_URI, localName, JAVAEE_NS_PREFIX);
Review Comment:
This look inconsistent with the `chreateBindingsQName` method. Ar you sure
these are changed independently?
##########
enterprise/j2ee.dd/src/org/netbeans/modules/j2ee/dd/api/application/Application.java:
##########
@@ -47,11 +47,12 @@ public interface Application extends
org.netbeans.modules.j2ee.dd.api.common.Roo
* @since 2
*/
public static final String VERSION_8 = "8"; //NOI18N
+ public static final String VERSION_9 = "9";
//NOI18N
Review Comment:
Alignmet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
