mbien commented on code in PR #4404:
URL: https://github.com/apache/netbeans/pull/4404#discussion_r924609280
##########
apisupport/maven.apisupport/src/org/netbeans/modules/maven/apisupport/MavenPackageModifierImpl.java:
##########
@@ -211,11 +211,17 @@ private POMExtensibilityElement
createPublicPackagesElement(org.netbeans.modules
bld = p.getModel().getFactory().createBuild();
p.setBuild(bld);
}
+ // check old groupid of nbm maven plugin
Plugin plug = bld.findPluginById("org.codehaus.mojo",
"nbm-maven-plugin");
+ // check new groupid of nbm maven plugins
+ if (plug == null) {
+ plug =
bld.findPluginById("org.apache.netbeans.utilities", "nbm-maven-plugin");
+ }
Review Comment:
can you put this into a method since it is duplicated twice. For example:
`Plugin plug = findNbmPluginOf(build)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
