matthiasblaesing commented on PR #4420: URL: https://github.com/apache/netbeans/pull/4420#issuecomment-1193159342
> Out of interest, why the additional module dependencies? Artifacts from a first try. I tried to follow the JNA example to closely (the JNA module is using a module Installer, which junixsocket does not need). I removed the installer and the manifest changes, regrettably the changes to the dependencies were retained. I pushed an updated PR. The corresponding binary: https://doppel-helix.eu/NetBeans-dev-dev-97f2a4617b23c157eee90abbcb6159fd9bda188f-release.zip This does not invalidate tests done with the original change, as the depencies are not the critical path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
