mbien commented on PR #3860: URL: https://github.com/apache/netbeans/pull/3860#issuecomment-1195285973
> @mbien just realised that one of the JARs listed above that has a lot of MRJ affected classes is lucene. Anything of concern? Possible source of any current issues? @neilcsmith-net i looked into the jar and it has a version 9 in it. And the default is 8. Diffing with the decompiler showed that lucene is doing MRJ to get some extra APIs from `java.lang.Objects` and similar earlier. If thats all they are using it for, it wouldn't even matter what version is loaded on 11+, since they provided their own "FutureObjects" impl for 8 obviously (looks like unnecessary complexity to me tbh, but I haven't diffed everything). They don't track the lucene 8.x branch on github anymore, we are using an EOL version and lucene 9+ moved to JDK 11+. We patched a single file https://github.com/mbien/netbeans/blob/ec298fb6fae9185dfd2716054e124ec37647fd31/java/maven.indexer/src/org/apache/lucene/search/MultiTermQuery.java in #3558, this file has only one version in lucene-core-8.11.1.jar - nothing can go wrong there either. I assume you are asking because the "default" jar was loaded before, but after the change the "correct version" will be picked, which would be 9 in lucene's case? I don't think this will cause problems. (also holy cow I just edited your post instead of commenting in my own, i need a coffee haha) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
