SirIntellegence commented on code in PR #4440:
URL: https://github.com/apache/netbeans/pull/4440#discussion_r931638729
##########
java/java.completion/src/org/netbeans/modules/java/completion/JavaCompletionTask.java:
##########
@@ -3890,6 +3882,33 @@ && isOfKindAndType(e.getEnclosingElement().asType(), e,
kinds, baseType, scope,
}
return false;
}
+
+ private boolean checkMethodAccepted(String sn, Element e,
+ TypeMirror t) {
+ //4 checks to include property accessors
+ String initialPrefix = env.getPrefix();
+ //TODO: maybe cache these?
+ String[] prefixes = {
+ initialPrefix,
+ "is" + initialPrefix,
+ "get" + initialPrefix,
+ "set" + initialPrefix
+ };
+ for (String prefix : prefixes) {
+ if (checkMethodAccepted(sn, prefix, e, t)){
+ return true;
+ }
+ }
+ return false;
Review Comment:
I see... I could possibly take a look at it later... But I don't know if I
will have the time. That logic is only invoked for filtering methods though,
not fields, but I see your point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
