pepness opened a new pull request, #4454: URL: https://github.com/apache/netbeans/pull/4454
Cleanup: - Remove unnecessary if/return statement - Add missing braces - Add missing `@Override` annotations - Use diamond inference - Use try-with-resources - Use StandardCharsets instead of a String - String concatenation in logger - Use multi-catch and a more specific catch - Improve Collection.toArray - Length one String literal in String.indexOf - Looks for string concatenation in StringBuilder - Replace StringBuffer with StringBuilder when not necessary Testing: - Full build done - Verify successful execution of libraries and licenses Ant test - Verify successful execution of Sigtests - Verify successful execution of commit-validation - Verify successful execution of rat-exclusions - Verify successful execution of `enterprise.tomcat5` unit tests - Started NetBeans and ensure the log didn't have any ERROR or new WARNINGS After this, I plan to improve Tomcat/TomEE support for Jakarta EE 9/9.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
