sdedic commented on code in PR #4448:
URL: https://github.com/apache/netbeans/pull/4448#discussion_r934034526


##########
java/java.editor/src/org/netbeans/modules/java/editor/fold/JavaElementFoldManager.java:
##########
@@ -75,8 +75,8 @@ public class JavaElementFoldManager implements FoldManager {
     public static final FoldType JAVADOC_FOLD_TYPE = 
FoldType.DOCUMENTATION.derive("javadoc", Bundle.FoldType_Javadoc(), 
             new org.netbeans.api.editor.fold.FoldTemplate(3, 2, "/**...*/")); 
// NOI18N
 
-    @NbBundle.Messages("FoldType_Methods=Methods")
-    public static final FoldType CODE_BLOCK_FOLD_TYPE = 
FoldType.MEMBER.derive("method", Bundle.FoldType_Methods(), 

Review Comment:
   Please do not **rename** an existing fold type -- this will break user 
settings. Instead, add an additional FoldType  - derive from nothing or 
FoldType.CODE_BLOCK.
   
   Then adjust the code to use the new fold type for blocks, fors, ...
   
   Such setup allows the user to control inner code folds and method-level 
folds separately, i.e. if one sets methods to be collapsed by default, the code 
blocks won't be initially collapsed when the user expands a method element.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to