Chris2011 opened a new pull request, #4485: URL: https://github.com/apache/netbeans/pull/4485
This PR adds a new HTML Rule, Hint and HintFix for a missing "alt" attribute for following tags: img, applet, area. I copied over some code from existing ExtractInlinedStyleRule and ExtractInlinedStyleHint and checked it, how it works. Fun fact, atm ExtractInlinedStyleHintFix is not working atm, it will throw an NPE, but this is not broken due to my changes. I will try to fix this later, in a seperate PR. Please have a look into the code. I will handle this as a draft and I will change some things like to add the rule/hint to the layers.xml instead of the HtmlHintsProvider as mentioned in the comment. Also I changed a private method which gives you the exact offset of the tag <tag> or <img /> problem here is that I need to add the attribute before the closing token so I added a bool to change this behaviour just for my and future needs. The rest is still working as before. I also try to add tests for the hint, but there are atm no tests at all. I also notied the extra space before my " alt=\"\"" when it is a closing tag. I can also try to fix this to check for token WS but it is the same behaviour as for WebStorm. It is better than nothing IMHO.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
