mbien commented on code in PR #4429:
URL: https://github.com/apache/netbeans/pull/4429#discussion_r940636621
##########
ide/html.editor/test/unit/src/org/netbeans/modules/html/editor/completion/HtmlCompletionTestSupport.java:
##########
@@ -114,7 +113,7 @@ public void run() {
try {
assertCompletionItemNames(expectedItemsNames, items, type);
- } catch (AssertionFailedError e) {
+ } catch (AssertionError e) {
Review Comment:
the problem is that this is a public utility method with several usages. I
didn't want to rewrite too much and make this PR even larger. Simply catching
`AssertionError` seemed like the easiest solution.
It would have been dangerous if the utility method would call into NB code
which has java assert statements and the test would expect a junit assert
failure. If NB code would fail for the wrong reason, the test would pass
instead of fail. But this here should be safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
