mbien commented on code in PR #4490:
URL: https://github.com/apache/netbeans/pull/4490#discussion_r944555368
##########
platform/o.n.core/src/org/netbeans/core/NotifyExcPanel.java:
##########
@@ -484,32 +491,41 @@ public void run() {
}
} else {
ResourceBundle curBundle = NbBundle.getBundle
(NotifyExcPanel.class);
+ String message;
if (current.getSeverity() == Level.WARNING) {
// less scary message for warning level
- descriptor.setMessage (
- java.text.MessageFormat.format(
- curBundle.getString("NTF_ExceptionWarning"),
- new Object[] {
- current.getClassName ()
- }
- )
+ message = MessageFormat.format(
+ curBundle.getString("NTF_ExceptionWarning"),
+ new Object[] { current.getClassName() }
);
title = curBundle.getString("NTF_ExceptionWarningTitle");
// NOI18N
} else {
- // emphasize user-non-friendly exceptions
- // if (this.getMessage() == null ||
"".equals(this.getMessage())) { // NOI18N
- descriptor.setMessage (
- java.text.MessageFormat.format(
- curBundle.getString("NTF_ExceptionalException"),
- new Object[] {
- current.getClassName (),
- CLIOptions.getLogDir ()
- }
- )
+ message = MessageFormat.format(
+ curBundle.getString("NTF_ExceptionalException"),
+ new Object[] { current.getClassName(),
Paths.get(CLIOptions.getLogDir()).toUri() }
Review Comment:
this should hopefully work on windows. `getLogDir()` returns `new
File(...).toString()` and is parsed again to `Path` and then converted to `URI`
to finally insert it as hfref="file://" into the HTML :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
