tonihele commented on PR #4502: URL: https://github.com/apache/netbeans/pull/4502#issuecomment-1214307696
Could the performance still be increased if hashing is used instead of just traversing the methods list in a loop to find matches? Or with binary search? I don't know how many methods there are in average to take full advantage of this approach. But at least it would stay logarithmic. If this is changed into a Hashmap: `List<ExecutableElement> methodsIn = null;` And possibly a local wrapper class around ExecutableElement to create the appropriate `hashCode` and `equals` to serve the purpose? Or with binary search (`Collections.binarySearch()`) just create the comparer with no need of wrapping and sort once of course. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
