lkishalmi commented on PR #4517: URL: https://github.com/apache/netbeans/pull/4517#issuecomment-1221826551
Well, well... I see some of good improvements on the code, though some of these changes are a bit disturbing. And that is the auto-discovery of the task properties. Gradle evolved quite a lot during the last years. One of the direction they went is doing the lazy initialization of the tasks, by using task registration instead or actual instance creation. Though when you request a task, it will be instantiated. People are very creative to create really poor quality Gradle build scripts, so task instantiation can be really expensive. If you would like to experiment with this, then probably shall create a feature branch. Create a separate TaskInfoModel add it's own cache, and probably some loading infrastructure. I would not make the NbProjectInfo more bloated. To find out the directory and filename of the main jar is really easy right now (not fancy and shiny, but works in most cases): ```java GradleJavaProject gjp = GradlJavaProject.get(project); File jar = gjp.getMainJar(); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
