ratcashdev commented on code in PR #3995: URL: https://github.com/apache/netbeans/pull/3995#discussion_r960815805
########## ide/projectapi/src/org/netbeans/spi/project/SingleMethod.java: ########## @@ -54,6 +56,19 @@ public SingleMethod(FileObject file, String methodName) { this.methodName = methodName; } + public SingleMethod(FileObject file, String methodName, String enclosingType) { + super(); + if (file == null) { + throw new IllegalArgumentException("file is <null>"); Review Comment: just copied the existing code. Is NPE indeed better than the above? Or just a pure `Objects.requireNotNull()`... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists