lkishalmi commented on PR #4549: URL: https://github.com/apache/netbeans/pull/4549#issuecomment-1250340300
Just looked on the code, haven't merged it. In the CACHE you put `WeakReference` into a `WeakHashMap`. Isn't it too weak for a cache? The cache entry is not referenced in any way could be gone as soon as the code execution leaves the block. Could be better to use `SoftReference` instead, so it would be kept for a while. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
