sdedic commented on code in PR #4654:
URL: https://github.com/apache/netbeans/pull/4654#discussion_r976187007
##########
platform/openide.filesystems/test/unit/src/org/openide/filesystems/FileUtilTest.java:
##########
@@ -704,6 +709,24 @@ public void close() throws SecurityException {
assertTrue(result.toExternalForm().endsWith("/")); //NOI18N
}
+ public void testCopyPosixPerms() throws Exception {
+ if (Utilities.isWindows()) return;
Review Comment:
can use `assumeFalse()`, the test will appear as 'skipped' in results.
##########
platform/openide.filesystems/apichanges.xml:
##########
@@ -25,6 +25,30 @@
<apidef name="filesystems">Filesystems API</apidef>
</apidefs>
<changes>
+ <change id="fileutil.copyposixperms">
+ <api name="filesystems"/>
+ <summary>FileObject copy preserves source posix
permissions.</summary>
+ <version major="9" minor="30"/>
Review Comment:
Bump version in `manifest.mf` too
##########
platform/openide.filesystems/apichanges.xml:
##########
@@ -25,6 +25,30 @@
<apidef name="filesystems">Filesystems API</apidef>
</apidefs>
<changes>
+ <change id="fileutil.copyposixperms">
+ <api name="filesystems"/>
+ <summary>FileObject copy preserves source posix
permissions.</summary>
+ <version major="9" minor="30"/>
+ <date day="18" month="9" year="2022"/>
+ <author login="lkishalmi"/>
+ <compatibility addition="yes" semantic="compatible"/>
+ <description>
+ <a
href="@TOP@/org/openide/filesystems/FileUtil.html#">FileUtil.copy</a> now
preserves POSIX permissions if possible during file copy.
Review Comment:
missing anchor to the FileUtil.copy chapter ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
