mbien commented on issue #4732: URL: https://github.com/apache/netbeans/issues/4732#issuecomment-1271566227
let me think about this. The URL encoded String is used as file name. This isn't optimal because this could hit the file name length limit on windows (which is still 255 chars I believe). `тест` would be encoded to `%D1%82%D0%B5%D1%81%D1%82` using `java.net.URLEncoder`. Which means that `тесттесттесттесттесттесттесттесттесттесттест` would break the limit. Maybe this is long enough? :) > I would try to do this tests, but i don't have experience to compile full IDE. Is it possible make it only for bugtracking module? You have to build netbeans once via command line (https://github.com/apache/netbeans#building-netbeans). After that, simply open the bugtracking module in NetBeans and you can build and test it like a normal project. > Is a good practice - making tests who will fails testing step because errors is not fixed yet? if we end up using `java.net.URLEncoder/Decoder` we won't need more tests because this would test JDK code. But to answer the question: I believe it would be best to add a test which demonstrates the issue to the same commit which fixes the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
