matthiasblaesing commented on PR #4845: URL: https://github.com/apache/netbeans/pull/4845#issuecomment-1296272324
This is major problem and this moves antlr for me into the corner of "you should not use it". This is not antlr 4.11, but 5.1 (4.10 broke compatibility). From my POV we have to treat it as such. At least we have to bump the release version, so the module would then be named `org.netbeans.libs.antlr4.runtime/2`. Or a new module is created, that holds versions 4.10+. I have seen antrl4 in the truffle area, so all depending modules need to be checked. The changes to the JSON parser look sane to me. These cause unittest errors in `javascript2.editor` module, but these look harmless (Patch: [javascript2.editor.zip](https://github.com/apache/netbeans/files/9896046/javascript2.editor.zip)). The transitive problems seem to be much harder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
