neilcsmith-net commented on code in PR #4899:
URL: https://github.com/apache/netbeans/pull/4899#discussion_r1011606353
##########
java/maven/src/org/netbeans/modules/maven/classpath/ClassPathProviderImpl.java:
##########
@@ -721,18 +722,14 @@ public AnnotationPathSelector(NbMavenProjectImpl proj,
ClassPath anno, Supplier<
this.annotationCP = anno;
this.compileClassPath = compile;
- anno.addPropertyChangeListener(WeakListeners.propertyChange(
- e -> {
- active = null;
- support.firePropertyChange(PROP_ACTIVE_CLASS_PATH,
null, null);
- }, ClassPath.PROP_ROOTS, anno
- ));
-// proj.getProjectWatcher().addPropertyChangeListener((e) -> {
-// if (NbMavenProject.PROP_PROJECT.equals(e.getPropertyName()))
{
-// active = null;
-// support.firePropertyChange(PROP_ACTIVE_CLASS_PATH, null,
null);
-// }
-// });
+ anno.addPropertyChangeListener(WeakListeners.propertyChange(this,
anno));
+
proj.getProjectWatcher().addPropertyChangeListener(WeakListeners.propertyChange(this,
anno));
Review Comment:
@sdedic added a second commit that fixes the source passed to WeakListeners.
Other than that are you happy with @timboudreau changes going in to 16-rc3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
