eirikbakke opened a new pull request, #4: URL: https://github.com/apache/netbeans-native-launchers/pull/4
Currently, NetBeans will refuse to run on Windows if any non-ASCII characters are detected in the installation directory's path. See https://github.com/apache/netbeans/issues/4314 . This is not always necessary. The condition to be guarded against here was not quite correct. The underlying problem is not with characters that are not in ASCII characters (32-127), but rather with characters that cannot be represented in the default Windows codepage. This is because the JNI interface expects JVM parameters (e.g. classpath) to be passed this way. Thus, certain international characters, such as the Norwegian characters æøå, are not a problem on, say US Windows (which uses codepage windows-1252), whereas others may be (e.g. Cyrillic Андрей if not using a Cyrillic codepage). In fact, the old "Cannot be run from folder that contains non-ASCII characters in path." warning would _only_ be shown in cases that were actually OK, and omitted in all cases where it should have been shown (where characters were replaced by question mark by Win32 API functions). This PR adjusts the condition to show a friendly error message when NetBeans cannot actually be run, and avoids showing the message when it should be safe to run NetBeans. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
