mbien commented on code in PR #4975:
URL: https://github.com/apache/netbeans/pull/4975#discussion_r1024323601
##########
nbbuild/antsrc/org/netbeans/nbbuild/CustomJavac.java:
##########
@@ -226,12 +226,16 @@ private void cleanUpDependDebris() {
continue;
}
int i = clazz.indexOf('$');
- File enclosing = new File(d, clazz.substring(0, i) + ".class");
- if (!enclosing.isFile()) {
- File enclosed = new File(d, clazz);
- log(clazz + " will be deleted since " + enclosing.getName() +
" is missing", Project.MSG_VERBOSE);
- if (!enclosed.delete()) {
- throw new BuildException("could not delete " + enclosed,
getLocation());
+ // ignore filenames that start right with '$' (separatorChar
preceded), these could not be inner classes.
+ if (i > 0 && clazz.charAt(i - 1) != File.separatorChar) {
+ File enclosing = new File(d, clazz.substring(0, i) + ".class");
Review Comment:
`clazz.substring(0, i).concat(".class")` would be fine with me since its a
low impact change readability wise (but I don't think it is necessary ;)).
This code would use invoke dynamic as soon we decide to rise the language
level above 8. You can't do much faster than `+` in modern java. It already
knows all the tricks.
There are some exceptions when SB will be faster e.g if you build something
in a loop, esp if you can pre-allocate it. But for simple cases: don't worry
about `+`.
here a talk by Heinz Kabutz which goes into details:
https://www.youtube.com/watch?v=z3yu1kjtcok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
