matthiasblaesing commented on code in PR #4986:
URL: https://github.com/apache/netbeans/pull/4986#discussion_r1028489850
##########
ide/css.editor/src/org/netbeans/modules/css/editor/module/main/BrowserSupportModule.java:
##########
@@ -66,7 +66,12 @@ public Collection<String> getPropertyNames(FileObject file) {
@Override
public PropertyDefinition getPropertyDefinition(String propertyName) {
- return parser.getVendorSpecificProperties().get(propertyName);
+ PropertyDefinition pd =
parser.getVendorSpecificProperties().get(propertyName);
Review Comment:
I don't understand what is the relevance of this question. If there was a
problem before this change it is still there. This is not the point of the
changeset.
To answer the question:
`BrowserSpecificDefinitionParser#getVendorSpecificProperties` is backed by a
`HashSet`. This allows `null` as key. The parser though will not yield `null`
keys, so the `null` will not have a backing value, yielding `null` fro the
`PropertyDefinition`. This in turn is caught in the new line 70, which
explicitly checks for `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
