jglick commented on code in PR #5099:
URL: https://github.com/apache/netbeans/pull/5099#discussion_r1049993480
##########
java/maven/src/org/netbeans/modules/maven/execute/CommandLineOutputHandler.java:
##########
@@ -319,15 +321,20 @@ private String readLine() throws IOException {
}
Matcher lineMatcher = linePattern.matcher(line);
if (lineMatcher.matches()) {
- Level level = Level.valueOf(lineMatcher.group(1));
- String text = lineMatcher.group(2);
- updateFoldForException(text);
-
processLine(MavenSettings.getDefault().isShowLoggingLevel() ? line : text,
stdOut, level);
+ String level_group = lineMatcher.group(1);
+ Level level = mapLevel(lineMatcher.group(2));
+ String msg = lineMatcher.group(3);
Review Comment:
The groups are fine, just took me staring at it for a few minutes to figure
out what they were. Code comments giving examples of each matching value (or a
note that it may be null) would be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
