matthiasblaesing commented on code in PR #5107:
URL: https://github.com/apache/netbeans/pull/5107#discussion_r1051430549
##########
java/javadoc/nbproject/project.properties:
##########
@@ -25,3 +25,6 @@ spec.version.base=1.74.0
test.config.stableBTD.includes=\
**/hints/AnalyzerTest.class,\
**/search/*Test.class
+
+# failing
+test.config.default.excludes=**/search/*Test.class
Review Comment:
Indeed we are - I compared with the old `netbeans-releases` repository and
there the javadoc index files are present.
##########
java/java.lexer/nbproject/project.properties:
##########
@@ -21,6 +21,11 @@ javac.source=1.8
javadoc.title=Java Lexer API
javadoc.apichanges=${basedir}/apichanges.xml
+test.config.default.excludes=\
+ **/JavaLexerPerformanceTest.class,\
+ **/JavaFlyTokensTest.class,\
+ **/JavaTokenDumpTest.class
Review Comment:
The `JavaTokenDumpTest` can be fixed like this:
```diff
--- a/java/java.lexer/test/unit/data/testfiles/testInput.java.txt.tokens.txt
+++ b/java/java.lexer/test/unit/data/testfiles/testInput.java.txt.tokens.txt
@@ -41,7 +41,7 @@
----- EOF -----
.t.e.s.t. String Literals
-STRING_LITERAL """"
+STRING_LITERAL """", la=1
WHITESPACE " ", la=1
STRING_LITERAL ""a""
WHITESPACE "\n", la=1
```
It also looks sane. When the lexer works on `"|" "a"` (| marks read
position) and reads the next char `"`, it has to decide whether this is the end
of an old style string (single quote) or the second quote char of a multiline
string start `"""`. So with the addition of multiline strings look-ahead became
necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
