neilcsmith-net commented on code in PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#discussion_r1056534714
##########
platform/core.multitabs/src/org/netbeans/core/multitabs/impl/TabDataRenderer.java:
##########
@@ -238,10 +238,10 @@ public void paint( Graphics g ) {
switch (tabsLocation) {
default:
case JTabbedPane.TOP:
- g.fillRect(0, rect.height - underlineHeight,
rect.width, underlineHeight);
+ g.fillRect(0, 0, rect.width, underlineHeight);
break;
case JTabbedPane.BOTTOM:
- g.fillRect(0, 0, rect.width, underlineHeight);
+ g.fillRect(0, rect.height - underlineHeight,
rect.width, underlineHeight);
break;
Review Comment:
@mbien thanks, but thinking about this more, it would be better to swap the
underline position based on the value of `EditorTab.underlineAtTop` as used at
https://github.com/apache/netbeans/blob/master/platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/ui/FlatEditorTabCellRenderer.java#L68
? That should keep it consistent.
For same reason, I'd probably swap the horizontal tabs line position on the
same flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
