mbien commented on code in PR #5144:
URL: https://github.com/apache/netbeans/pull/5144#discussion_r1056855420


##########
ide/xml.wsdl.model/test/unit/src/org/netbeans/modules/xml/wsdl/validator/WSDLSchemaValidatorTest.java:
##########
@@ -167,7 +168,13 @@ private void validate(URI uri, int expectedErrorCount)
         assertNotNull(vr.getValidationResult());
         
         ValidationHelper.dumpErrors(vr);
-        assertTrue("expect error " + expectedErrorCount,  
vr.getValidationResult().size() == expectedErrorCount);
+        
+        // some missing element errors appear twice on newer JDKs

Review Comment:
   might depend on the update release version since it is also reproducible on 
JDK 11 with the zulu distribution:
   
https://github.com/apache/netbeans/actions/runs/3761176522/jobs/6394078954#step:94:2272
   ```
        [junit] Testcase: 
testValidateMessageNoName(org.netbeans.modules.xml.wsdl.validator.WSDLSchemaValidatorTest):
   FAILED
       [junit] expect error 2
       [junit] junit.framework.AssertionFailedError: expect error 2
       [junit]  at 
org.netbeans.modules.xml.wsdl.validator.WSDLSchemaValidatorTest.validate(WSDLSchemaValidatorTest.java:170)
   
   ```
   
   i vaguely remember that xml libs got an update in OpenJDK, I just don't know 
the backporting rules for things like that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to