lkishalmi opened a new pull request, #5158:
URL: https://github.com/apache/netbeans/pull/5158

   This one is about evolving the Java Runtime selection further, beyond the 
recent patches, that made it possible in NB16u1. 
   
   The old implementation was mimicking what Maven/Ant does at the 
Build/Compile customizer. Those days the runtime platform pretty much 
determined the compile platform as well. The introduction of [JVM 
Toolchains](https://docs.gradle.org/current/userguide/toolchains.html) made 
that different. 
   
   Nowadays it is enough to have the JRE installed to start a Gradle build, 
Gradle can download and use different JVM-s if needed.
   
   I also made the Java Runtime selection available on root project only, 
sub-projects would take the root project setting.
   
   That's why the `GradleJavaRuntimeManager` and `JavaRuntime` got introduced 
as an API. Feedbacks on that are welcome, I think it's good enough, but could 
be improved to be more future proof.
   
   I've implemented this as a series of commits, so reviewing might be easier 
that way. JavaDoc and API doc would be provided later and in this PR.
   
   Eventually I would like to deprecate all the methods in JavaRunUtils, but 
they are used in the BootClasspath support at the moment. The bootclasspath 
support is not JVM Toolchain aware now, so that needs to be addressed, though I 
thought that would be a separate PR.
   
   
![image](https://user-images.githubusercontent.com/1381701/209917831-85bfe2a8-f027-4431-ba1e-8bd6669597b6.png)
   
    Changed to
   
   
![image](https://user-images.githubusercontent.com/1381701/209917955-42956db1-1974-40a1-acc5-b3d90c265786.png)
   
   While the `Build/Compile` customizer got removed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to