mbien commented on PR #5061:
URL: https://github.com/apache/netbeans/pull/5061#issuecomment-1375072589
@matthiasblaesing I agree. I believe @lkishalmi already talked about this
[here](https://github.com/apache/netbeans/pull/5115#issuecomment-1363182797).
Things like this can be a big time sink for reviewers since the first concern
are regressions caused by the refactoring of old tests. The benefit of having
nicer looking tests is minimal.
The project has also no lack of tests, its more a lack of resources to run
them all at once and also a test reliability problem of often failing tests in
some areas.
There are commented out tests here which probably need fixes otherwise they
wouldn't be commented out in the first place:
https://github.com/apache/netbeans/blob/master/.github/workflows/main.yml
There are a whole bunch of tests which can't run on JDK 11 which need fixes
(but this one is hard since the easy ones are probably already fixed):
https://github.com/apache/netbeans/issues/4904
So there is a lot of test related work available. Its just that refactoring
already working tests isn't really solving anything right now.
That being said, I know that you only want to help which is appreciated -
believe me. Merging this now. @lbownik thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
