lkishalmi commented on PR #5206: URL: https://github.com/apache/netbeans/pull/5206#issuecomment-1375999133
Well, this one does not introduce something big/groundbreaking. It's only 4 classes. Two of them: `AbstractAntlrLexerBridge` and `LexerInputCharStream` are actually implementations of an existing API. The `AbstractAntlrLexerBridge.LexerState` duties and usage is strict and well defined, that leaves `AntlrTokenSequence` as new here. That one is also simple and straight forward enough. I could imagine that there could be bugs in the implementation, though I'd not expect the API change without keeping backward compatibility any time soon. (Unless ANTLR forces us to do so...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
