matthiasblaesing commented on PR #4692: URL: https://github.com/apache/netbeans/pull/4692#issuecomment-1377790577
> OK, looks like the test might be broken?! Thread on dev@ might be good, but maybe should disable commit validation test on JDK 8 temporarily at least to get this in? I'll try and take a look sometime - it's not just about passing on JDK 8 - I presume we'll have the same issue with this test on JDK 11 when we bring in JDK 17+ modules at some point. In this case the test is questionable in its current form. The problem is: `org.netbeans.modules.j2ee.kit` depends on `org.netbeans.modules.jakartaee10.platform` and `org.netbeans.modules.jakartaee10.api` which are JDK 11+ only. The test accounts for modules that can't be loaded because the JDK requirement is not satisfied. But the kit fails to load because transitive modules can't be loaded. The test is right in that the j2ee kit is broken on a JDK < 11. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
