neilcsmith-net commented on PR #4692:
URL: https://github.com/apache/netbeans/pull/4692#issuecomment-1379510134

   > @neilcsmith-net I tried `OpenIDE-Module-Recommends` locally and it didn't 
pass, I see @jGauravGupta just pushed `OpenIDE-Module-Java-Dependencies` and it 
didn't help either.
   
   @mbien @jGauravGupta I think this might work - 
https://github.com/neilcsmith-net/netbeans/commit/5d3aa156d7807aeec74821ec0911c6bebdafc27d
   
   Did you add `is.autoload=true`?  Took me a couple of failed attempts to 
realise that was the missing element compared to the working Disco module.  
Couldn't get recommends to work with the module name, so added tokens and 
provides.  Passes tests locally and running on JDK 8 and JDK 11 seems to work 
as expected.  EE area is not one I know, though!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to