mbien commented on code in PR #4692:
URL: https://github.com/apache/netbeans/pull/4692#discussion_r1072770765
##########
enterprise/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/ide/WildflyJ2eePlatformFactory.java:
##########
@@ -137,23 +156,26 @@ public J2eePlatformImplImpl(WildFlyProperties properties)
{
@Override
public Set<org.netbeans.api.j2ee.core.Profile> getSupportedProfiles() {
if (this.properties.isWildfly()) {
- if(this.properties.isServletOnly()) {
+ if (this.properties.isServletOnly()) {
+ if
(this.properties.getServerVersion().compareToIgnoreUpdate(WildflyPluginUtils.WILDFLY_27_0_0)
>= 0) {
+ return
Collections.unmodifiableSet(JAKARTAEE_WEB_PROFILES);
+ }
return Collections.unmodifiableSet(WILDFLY_WEB_PROFILES);
}
+ if
(this.properties.getServerVersion().compareToIgnoreUpdate(WildflyPluginUtils.WILDFLY_27_0_0)
>= 0) {
+ return
Collections.unmodifiableSet(JAKARTAEE_FULL_PROFILES);
+ }
return Collections.unmodifiableSet(WILDFLY_PROFILES);
}
-
if(this.properties.getServerVersion().compareToIgnoreUpdate(WildflyPluginUtils.EAP_7_0)
>= 0) {
+ if
(this.properties.getServerVersion().compareToIgnoreUpdate(WildflyPluginUtils.EAP_7_0)
>= 0) {
return Collections.unmodifiableSet(WILDFLY_PROFILES);
}
Review Comment:
if you want to cherry pick:
https://github.com/mbien/netbeans/commit/02e614160423225f61180ed4b13f89a29a0f10fb
I can could prepare a followup PR (for RC2 or right after this) or you
commit it yourself, whatever is more convenient for you.
https://github.com/mbien/netbeans/tree/pr-4692 is a copy of this PR + my
commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
