BradWalker commented on code in PR #5320:
URL: https://github.com/apache/netbeans/pull/5320#discussion_r1080773912
##########
enterprise/j2ee.ejbcore/src/org/netbeans/modules/j2ee/ejbcore/action/HomeMethodGenerator.java:
##########
@@ -73,7 +73,7 @@ public void generate(MethodModel methodModel, boolean
generateLocal, boolean gen
// remote interface
if (generateRemote && remoteHome != null) {
- List<String> exceptions = exceptions = new
ArrayList<String>(methodModel.getExceptions());
+ List<String> exceptions = new
ArrayList<String>(methodModel.getExceptions());
Review Comment:
Since we're here.. I would mkae this into ArrayList<>..
##########
profiler/profiler.heapwalker/src/org/netbeans/modules/profiler/heapwalk/ui/ReferencesBrowserControllerUI.java:
##########
@@ -354,9 +354,9 @@ public void run() {
});
// ---
} else {
- Object[] shortPath = new Object[length];
- System.arraycopy(path, 0, shortPath, 0, length);
- final TreePath p = new TreePath(shortPath);
+// Object[] shortPath = new Object[length];
+// System.arraycopy(path, 0, shortPath, 0, length);
+// final TreePath p = new TreePath(shortPath);
SwingUtilities.invokeLater(new Runnable() {
Review Comment:
Not used, remove it..
##########
nbi/engine/src/org/netbeans/installer/utils/system/launchers/impl/CommonLauncher.java:
##########
@@ -95,7 +95,7 @@ protected long addData(FileOutputStream fos, File file,
Progress progress, long
//add rnd data
protected void addData(FileOutputStream fos) throws IOException {
- double rand = Math.random() * Byte.MAX_VALUE;
+ //double rand = Math.random() * Byte.MAX_VALUE;
Review Comment:
Remove both comments.. Dead code elimination..
##########
platform/masterfs/src/org/netbeans/modules/masterfs/ProvidedExtensionsProxy.java:
##########
@@ -79,7 +79,7 @@ public ProvidedExtensions.DeleteHandler
getDeleteHandler(final File f) {
}
public ProvidedExtensions.IOHandler getRenameHandler(final File from,
final String newName) {
- final File to = new File(from.getParentFile(), newName);
+// final File to = new File(from.getParentFile(), newName);
Review Comment:
If it's not used, remove it..
##########
platform/o.n.swing.plaf/src/org/netbeans/swing/plaf/nimbus/NimbusLFCustoms.java:
##########
@@ -45,7 +45,7 @@ public Object[] createLookAndFeelCustomizationKeysAndValues()
{
}
//XXX fetch the custom font size here instead
- Font controlFont = new Font("Dialog", Font.PLAIN, fontsize); //NOI18N
+ //Font controlFont = new Font("Dialog", Font.PLAIN, fontsize); //NOI18N
Review Comment:
If it's not used, remove it..
##########
platform/openide.filesystems/src/org/openide/filesystems/AbstractFolder.java:
##########
@@ -820,7 +820,7 @@ protected final void refreshFolder(
fire && (added == null) && (removed == null) &&
!getFileSystem().isReadOnly() &&
!(this instanceof MultiFileObject)
) {
- Set<String> nameFilter = nameFilter = new HashSet<String>();
+ Set<String> nameFilter = new HashSet<String>();
Review Comment:
Change to HastSet<>
##########
platform/api.visual/src/org/netbeans/modules/visual/anchor/DefaultAnchorShapeResolver.java:
##########
@@ -62,7 +62,7 @@ public int getEndLocation()
else
{
// Rectangle bounds = attachedWidget.getBounds();
- Rectangle bounds = new Rectangle();
+ Rectangle bounds;
Review Comment:
I would split the declaration and assignment into:
Widget sourceWidget;
And then refactor the code to remove the use of bounds..
##########
platform/o.n.swing.tabcontrol/demosrc/org/netbeans/swing/tabcontrol/demo/TestFrame.java:
##########
@@ -189,7 +189,7 @@ public void actionPerformed(ActionEvent ae) {
jb9.addActionListener(new ActionListener() {
public void actionPerformed(ActionEvent ae) {
- int[] idxs = new int [] { 1, 3, 6, 8};
+ //int[] idxs = new int [] { 1, 3, 6, 8};
Review Comment:
Not used, remove it..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
