neilcsmith-net commented on code in PR #5361:
URL: https://github.com/apache/netbeans/pull/5361#discussion_r1088943940
##########
ide/db/src/org/netbeans/modules/db/explorer/action/ConnectAction.java:
##########
@@ -62,63 +63,63 @@
import org.openide.awt.ActionReference;
import org.openide.awt.ActionRegistration;
import org.openide.awt.ActionState;
-import org.openide.awt.StatusDisplayer;
+import org.openide.util.ContextAwareAction;
import org.openide.util.HelpCtx;
import org.openide.util.Lookup;
import org.openide.util.Mutex;
import org.openide.util.NbBundle;
+import org.openide.util.RequestProcessor;
+import org.openide.util.WeakListeners;
@ActionRegistration(
displayName = "#Connect",
- lazy = false,
+ lazy = true,
+ asynchronous = true,
Review Comment:
Generally prefer the RequestProcessor approach, but hadn't considered the
infrastructure tracking side. Just been caught a few times (mainly in RCP
work) by actions triggering chains of things unexpectedly off of the EDT.
I understand why you want to change it for the headless mode. I assume
there are no existing usages where the action not being completed by return is
a problem?
Anyway, assuming no implications to changing the existing action, no
concerns with it as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
