vieiro commented on PR #5214:
URL: https://github.com/apache/netbeans/pull/5214#issuecomment-1407479147
Hi @tbw777 ,
The fact is that the Java compiler ignores "static" in inner interfaces and
enums. The bytecode is exactly the same. You can test this yourself compiling
these simple classes:
```java
package a.b.c;
public class A {
public static interface AA {}
public static enum AAA {}
}
```
and
```java
package a.b.c;
public class B {
public interface BB {}
public enum BBB {}
}
```
If you compile these classes with `javac` you'll see that the generated
`A.class` and `B.class` have exactly the same size.
This does not affect performance, either. Since the generated bytecode is
exactly the same the performance will be the same.
The fact is that this PR makes no difference to NetBeans. There will be no
difference in performance, network consumption, etc.
We may approve it, since it does some cleaning of the source code, but I
will have to review those 729 files, one by one, that you have changed, to make
sure all your changes are correct. This is going to take some time to me,
because I don't work for this. Maybe one week or two.
During these two weeks I won't be able to do anything else, I'm afraid.
Maybe next time you send a PR you can ask in the mailing list if the PR is
worth the effort reviewing, because we would prefer adding new features to
NetBeans instead of reviewing PRs that make no difference in performance. What
say?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
