neilcsmith-net commented on PR #5387: URL: https://github.com/apache/netbeans/pull/5387#issuecomment-1408241853
> OK, the issue is that both changes of #5353 (now present in master and vsnetbeans_1603) AND #5363 (now present in delivery and vsnetbeans_1603) are needed IMHO in NB17 (= delivery). The correct file's content is the one in vsnetbeans_1603 branch. Yes, but there are two more files changed in #5353 ? Don't you need the new versions of `AddADBAction` and `DownloadWalletDialog` in NB17 as well? > should that new PR replace #5367 ? Yes. But it can't be done until after we merge #5366 , close delivery for the rc, and build / announce 17-rc3. As long as delivery has the right content before then, I can handle the sync side. And also as long as no-one touches those 3 files in master this week! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
