mbien commented on PR #5391:
URL: https://github.com/apache/netbeans/pull/5391#issuecomment-1409117114

   > Yes I was thinking determining if the theme is light/dark then apply fixed 
black/white colors for fonts
   
   if the background is taken from the theme, its ok to take the font color 
from the theme too. But as soon the background is changed, for example when set 
to orange, the color can't be taken from the theme anymore - it has to fit to 
the orange background.
   
   I wouldn't hardcode all font colors, only conditional when the background 
actually changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to