neilcsmith-net commented on PR #5379: URL: https://github.com/apache/netbeans/pull/5379#issuecomment-1410091412
> I cant quit this changes becouse it really fix bugs! And I am sure that sometimes they appear in rare cases! It's only a bug if it's a check against a non-interned String. Please re-read [JLS-3.10.5](https://docs.oracle.com/javase/specs/jls/se11/html/jls-3.html#jls-3.10.5) There are a few things in here where object identity rather than equality might be important. Try concentrating on cases where object identity isn't needed and the check is a non-interned String - that's a real bug, _if you find one_. Some of the other changes might be worth considering if identity is not important, if only to stop having this conversation in future rather than because there's a bug. That probably does need splitting down into multiple small PRs, because it's not code cleanup as you say. Offering money is pointless (and insulting)! Offer your time, address the concerns, and realise we're all trying to make NetBeans better. Locking this conversation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
