BradWalker commented on PR #5400: URL: https://github.com/apache/netbeans/pull/5400#issuecomment-1411955782
I NEVER touch tests. By definition, code might be executed that "doesn't make sense" just for the express purpose of executing a test. Also, unless the test is provably wrong, it's not justification to claim that code does nothing. Even if code does nothing, by definition, it's a test. So the fact that it does nothing, means it is doing something. Lastly, for example, the test ExtensionPropertiesExtractor.java, which you claim does nothing, is recent code as per the git log. A better method would have been to reach out to the author of this code and ask if it is really the intent of the test. Therefore, I'm closing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
