sdedic commented on PR #5413:
URL: https://github.com/apache/netbeans/pull/5413#issuecomment-1414421737

   Could you split the commit somewhat ? For example one commit per cluster ? 
It could be easier to review.
   
   Please note that while removing dead code is good, we must be more careful 
in Platform or IDE clusters - it's possible that some other module hacked into 
the implementation using Reflection. It should not been done in the first 
place, I agree completely ... but this kind of ... things... happens in such 
long-lived codebase.
   
   So please let's be careful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to