vieiro commented on code in PR #5432:
URL: https://github.com/apache/netbeans/pull/5432#discussion_r1096734291
##########
ide/css.lib/src/org/netbeans/modules/css/lib/api/properties/Properties.java:
##########
@@ -144,24 +146,26 @@ public static boolean isAggregatedProperty(FileObject
context, PropertyDefinitio
final GroupGrammarElement grammarElement =
propertyDefinition.getGrammarElement(context);
final AtomicBoolean isAggregated = new AtomicBoolean(false);
grammarElement.accept(new GrammarElementVisitor() {
- private boolean cancelled = false;
+ private final Map<GroupGrammarElement,Void> seen = new
IdentityHashMap<>();
Review Comment:
It's ok. Maybe`Collections.newSetFromMap(new IdentityHashMap<>()) ` makes
things clearer below (`seen.contains`, `seen.add`, etc.)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
