errael commented on PR #5309: URL: https://github.com/apache/netbeans/pull/5309#issuecomment-1418467020
> @errael side answer smile please don't squash and merge. Both GitHub UI and CLI have (different) negative side effects there. Do agree that multiple commits can be better when kept during reviews though. PR branches are generally writable by committers as well as authors, so squashing and force pushing into the PR branch (where warranted) for final checks before merging is ideal IMO. @neilcsmith-net I had always thought that references to `CLI` were about the `git` command. But I couldn't deny my ignorance anymore after reading what you said, yet another thing about git/github I didn't want to know. So if I get this right, a pattern is to push several commits to a PR, then after approval, can squash locally (using mercurial in my case) and force push to the PR. Does the compare button associated with a forced push after a local-squash/force-push show no changes (assuming, of course, that there were no changes)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
