matthiasblaesing commented on PR #5299: URL: https://github.com/apache/netbeans/pull/5299#issuecomment-1421373192
> While applying those changes, noticed that `getStringWithLengthControl` is declared to throw some exceptions. Should `isLittleEndian` throw the internal exceptions as well instead of catching them? I have mixed feelings here. The use sites don't give information about what went wrong, which would make it hard to debug. What would you think about this idea: let `isLittleEndian` throw all its exceptions, but add a multi catch for these before the finally-clause before 367, log errors there and rethrow. I would then not use `Exceptions#printStackTrace`, but a `java.util.Logger` on level INFO. `printStackTrace` creates useless message window. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
