neilcsmith-net commented on PR #5219: URL: https://github.com/apache/netbeans/pull/5219#issuecomment-1423012509
> I looked through this and I believe this should be fine @neilcsmith-net. A lot of this are language identifier comparisons, file endings, SQL queries etc. I think it looks so too, although I haven't had time to look at all areas (like bugzilla) yet. To be more explicit about what I was saying above, I think this should be evaluated as a bug fix. I'm more interested in that aspect of it than any minor performance improvements. And we should probably look for other uses of `to[U/L]Case()` that are not part of this but questionable, and should be using `Locale.ROOT` / `Locale.ENGLISH`. > Whenever there is a comparison with a constant like "dev" it shouldn't matter if the cases are compared with a specific local or not. That depends on what is being compared, and where the input string is from. Consider - ```java String input = "LIB"; boolean result = "lib".equals(input.toLowerCase()); ``` The result might be true or false depending on [whether you're Turkish or not](https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/String.html#toLowerCase())! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
