lkishalmi commented on PR #5464: URL: https://github.com/apache/netbeans/pull/5464#issuecomment-1426583670
Well, yet another set of ambivalent changes. Some of these could be valid, some of them indifferent and there are a few places, when it hurts the readability of the code a little. Object creation in Java is cheap, really cheap. Doing these optimization on exception handlers, test code, simply does not worth. Also there are a lot of places where the new code is more complex than the original one including a null check. that's just bad. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
