mbien commented on PR #5455: URL: https://github.com/apache/netbeans/pull/5455#issuecomment-1426792602
> Think we might have a little bit of work to do! smile I only searched for `javac.target`, so stupidly missed how many more modules just set `javac.source`! roll_eyes the reason for that is because the custom javac ant task is mapping the properties in a non-standard way: https://github.com/apache/netbeans/blob/master/nbbuild/antsrc/org/netbeans/nbbuild/CustomJavac.java#L68-L100 but we are getting there. The good thing is that all values are now basically the same. i saw this in the log `The Java platform version 8 or higher was requested but only 1.8 is running.` This indicates that i clearly overlooked some usages of the target property. Because this sounds like a module system warning so the number must have made it into the manifest. https://github.com/apache/netbeans/blob/410710ec8669a6134b508d28136627e39cab8d27/platform/autoupdate.services/src/org/netbeans/modules/autoupdate/services/DependencyChecker.java#L116 I did set source/target to 1.8 for the current test run. going to try to get the default release property in too so that we can use it for all the other javac calls, e.g https://github.com/apache/netbeans/pull/3278/commits/bf8c26d91ea20cb7bf29b4510938f572f2202034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
