mbien commented on code in PR #5332:
URL: https://github.com/apache/netbeans/pull/5332#discussion_r1108837654
##########
ide/bugtracking/src/org/netbeans/modules/bugtracking/RepositoryImpl.java:
##########
@@ -116,7 +116,7 @@ public void propertyChange(PropertyChangeEvent evt) {
}
Collection<QueryImpl> queries = new
ArrayList<>(getQueries());
synchronized(queryMap) {
- List<Q> toRemove = new LinkedList<Q>();
+ Set<Q> toRemove = new HashSet<>();
Review Comment:
i think NB code uses LL in places where there are only a handful of elements
expected. But I do agree that ALs are basically the right choice in 99% of all
cases, they create fewer objects and if you copy things around AL will always
win.
Some edge cases like insert-in-front can cause trouble though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
